Arm backend: use tosa_ref_model only if installed #13221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13221
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 12 Pending, 47 Unrelated FailuresAs of commit 74ebafa with merge base ec67249 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
digantdesai
force-pushed
the
tosa_ref_model
branch
from
79bb797 to
cf6f328
Compare
digantdesai
force-pushed
the
tosa_ref_model
branch
from
eada119 to
7932329
Compare
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D79887501. |
kirklandsign
approved these changes
Aug 8, 2025
Not making these tests XFail because there is still value in running these tests w/o validating output since we do go through a lot of other checks in the AoT flow when generating a PTE. TOSA ref model being not installed is not the common case anyway. Added explicit warnings (which should show through pytest unlike logger) as a reminder for the comparison is being skipped. Test: with and w/o tosa_reference_model installed locally
digantdesai
force-pushed
the
tosa_ref_model
branch
from
7cfa6f8 to
7579d91
Compare
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D79887501. |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D79887501. |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79887501 Pull Request resolved: pytorch#13221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not making these tests XFail because there is still value in running these tests w/o validating output since we do go through a lot of other checks in the AoT flow when generating a PTE.
Tosa ref model being not installed is not the common case anyway.
Added explicit warnings (which should show through pytest) as a reminder for the comparison is being skipped.
Test plan
local testing with pytest, with and without tosa_ref_model